Raise missing template errors from render_site_layout and render_menu
#2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2861 +/- ##
=======================================
Coverage 95.86% 95.86%
=======================================
Files 229 229
Lines 6211 6216 +5
=======================================
+ Hits 5954 5959 +5
Misses 257 257 ☔ View full report in Codecov by Sentry. |
tvdeyen
reviewed
May 7, 2024
mamhoff
force-pushed
the
error-on-non-existing-menu
branch
from
6793568 to
3d2a0e4
Compare
If we miss a partial, our specs should tell us.
When we miss a partial, we want to know (at least in the development and test environments).
mamhoff
force-pushed
the
error-on-non-existing-menu
branch
from
3d2a0e4 to
6e874f9
Compare
This extracts the error handling for missing templates into a helper method.
tvdeyen
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This raises an missing partial error in the test and development environments if there's a missing partial.
Notable changes (remove if none)
No changes in production, but better visibility on important errors in dev and test environments.
Checklist